[pickers] Use the new ownerState in <PickersCalendarHeader />, <PickersArrowSwitcher /> and <DayCalendarSkeleton />
#15499
Conversation
flaviendelangle
added
breaking change
component: pickers
|
Deploy preview: https://deploy-preview-15499--material-ui-x.netlify.app/ |
…owSwitcher and DayCalendarSkeleton
flaviendelangle
force-pushed
the
ownerState-various
branch
from
fd4865a
to
5c9341e
Compare
| <DayCalendarSkeletonDay | ||
| key={index2} | ||
| variant="circular" | ||
| width={DAY_SIZE} | ||
| height={DAY_SIZE} | ||
| className={classes.daySkeleton} | ||
| ownerState={{ day }} | ||
| data-day-in-month={dayInMonth} |
There was a problem hiding this comment.
I can create a DayCalendarSkeletonOwnerState but the component is probably not used a lot and even less overriden with styleOverrides so I went with simplicity here
|
|
||
| export type SlideDirection = 'right' | 'left'; | ||
|
|
||
| interface PickerSlideTransitionOwnerState extends PickerOwnerState { |
There was a problem hiding this comment.
It is not used in any styleOverrides, only in useUtilityClasses but I'm also unifying the parameters of this hook
...ickers/src/internals/components/PickersArrowSwitcher/describes.PickersArrowSwitcher.test.tsx
Outdated
Show resolved
Hide resolved
flaviendelangle
changed the title
ownerState in PickersCalendarHeader, PickersArrowSwitcher and DayCalendarSkeletonownerState in <PickersCalendarHeader />, <PickersArrowSwitcher /> and <DayCalendarSkeleton />
| const { ownerState: pickerOwnerState } = usePickerPrivateContext(); | ||
| const ownerState = { ...pickerOwnerState, slideDirection }; | ||
| const classes = useUtilityClasses(classesProp, ownerState); |
There was a problem hiding this comment.
very small performance thing: would it make sense here to prevent creating 2 additional objects?
| const { ownerState: pickerOwnerState } = usePickerPrivateContext(); | |
| const ownerState = { ...pickerOwnerState, slideDirection }; | |
| const classes = useUtilityClasses(classesProp, ownerState); | |
| const classes = useUtilityClasses(classesProp, { | |
| ...usePickerPrivateContext().ownerState, | |
| slideDirection, | |
| }); |
There was a problem hiding this comment.
For me we have the exact same amount of objects created with both approaches.
We only skip the creation of the pickerOwnerState and ownerState` variables (which are reference based since it's an object so for me it's negligeable)
Part of #14475